feat(provider/aws): Lambda function target support for AWS ALB #7630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion component. This is a refactoring change as requested by reviewer @caseyhebebrand Author: @sidmuls
This change is for refactoring requested by reviewer @caseyhebebrand. Author: @sidmuls
…ings. This change is a refactoring requested by @caseyhebebrand Author: @sidmuls
…etrying tests on TravisCI
…anges as requested by @christopherthielen Author: @sidmuls
fix(provider/aws): fixing import statement
fix(provider/aws): fixing property type for Entity Tags
…sted by @christophertheilen Author: @sidmuls
… not found in AmazonFunctionDetails.tsx. Author: @sidmuls
Merge remote-tracking branch 'upstream/master'
…nctionEnvironmentVariables.tsx Author: @sidmuls
…ug fix for filtering and displaying subnet Ids in Network section of functions modal. Author: @sidmuls
Merge branch 'master' of https://github.com/sidmuls/deck
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
…equest and response objects Author: @sidmuls
christopherthielen
requested changes
Nov 12, 2019
There was a problem hiding this comment.
@caseyhebebrand note that this PR is modifying the TargetGroups component and your PR will have conflicts. I think we should merge this Lambda PR first, then redo the changes from this PR into the newer TargetGroups.tsx component.
app/scripts/modules/amazon/src/function/configure/FunctionSettings.tsx
Outdated
Show resolved
Hide resolved
| @@ -29,6 +29,7 @@ export interface IAmazonFunction extends IFunction { | |||
| subnetIds: []; | |||
| vpcId: string; | |||
| }; | |||
| targetGroups: string | string[]; | |||
There was a problem hiding this comment.
Why is this typed asstring | string[]? Why not just type these as string[]?
There was a problem hiding this comment.
Currently we support adding only one target group instead of a list of target groups. Clouddriver expects it to be a string in Create/Update operation.
However, while fetching a function's details, AWS Lambda returns a list of string for the targetGroups field.
Hence the type string | string[]
app/scripts/modules/amazon/src/loadBalancer/configure/application/TargetGroups.tsx
Outdated
Show resolved
Hide resolved
| @@ -368,6 +368,7 @@ export class AwsLoadBalancerTransformer { | |||
| stickinessEnabled: targetGroup.attributes['stickiness.enabled'] === 'true', | |||
| stickinessType: targetGroup.attributes['stickiness.type'], | |||
| stickinessDuration: Number(targetGroup.attributes['stickiness.lb_cookie.duration_seconds']), | |||
| multiValueHeadersEnabled: targetGroup.attributes['multiValueHeaders.enabled'] === 'true', | |||
There was a problem hiding this comment.
should this be 'multiValueHeadersEnabled'?
There was a problem hiding this comment.
apologies!
it should be lambda.multiValueHeaders.enabled
that is the name of the flag used by AWS Lambda
I have fixed it and pushed the change
thank you so much for pointing it out
that was a great catch!
…da support for AWS Application load balancer Author: @sidmuls
christopherthielen
approved these changes
Nov 13, 2019
Sounds good! I probably won't have a chance to get mine merged for the next couple days, so this works out. |
sergiopena
pushed a commit
to sergiopena/deck
that referenced
this pull request
Jan 10, 2020
…aker#7630) * . * feat(provider/aws): Function listing and searching functionality This change adds a new tab for functions and facilitates listing existing functions and searching functions listed. Corresponding provider specific changes are included in this change for AWS. Authors: @sidmuls and @nabebe * feat(provider/aws): Function listing and searching functionality This change adds a new tab for functions and facilitates listing existing functions and searching functions listed. Corresponding provider specific changes are included in this change for AWS. Authors: @sidmuls and @nabebe * refactor(provider/aws): Converting Function class component into function component. This is a refactoring change as requested by reviewer @caseyhebebrand Author: @sidmuls * refactor(provider/aws): Refactoring groupings into a separate component. This change is for refactoring requested by reviewer @caseyhebebrand. Author: @sidmuls * refactor(provider/aws): Removing unnecessary state from FunctionGroupings. This change is a refactoring requested by @caseyhebebrand Author: @sidmuls * refactor(provider/aws): removing extra line. Tthis is actually for retrying tests on TravisCI * refactor(provider/aws): Adding tests for FunctionFilterService and changes as requested by @christopherthielen Author: @sidmuls * refactor(provider/aws): removing unnecessary field from IFunction * refactor(provider/aws): adding flag to turn off functions feature * feat(provider/aws): Function CREATE EDIT and DELETE feature. Author: @sidmuls and @nabebe * fix(provider/aws): fixing import statement Author: @sidmuls * fix(provider/aws): resolving merge conflicts * fix(provider/aws): fixing property type for Entity Tags Author: @sidmuls * fix(provider/aws): removing unnecessary component from AwsFunctionDetails Author: @sidmuls * refactor(provider/aws): fixing review comments by @caseyhebebrand Author: @sidmuls * refactor(provider/aws): changes for following best practices as requested by @christophertheilen Author: @sidmuls * refactor(provider/aws): Adding message to display in case function is not found in AmazonFunctionDetails.tsx. Author: @sidmuls * refactor(provider/aws): Replacing MapEditor with MapEditorInput in FunctionEnvironmentVariables.tsx Author: @sidmuls * refactor(provider/aws): fixes for comments requested by @christheilen Author: @sidmuls * refactor(provider/aws): changes as requested by @ChrisThielen and a bug fix for filtering and displaying subnet Ids in Network section of functions modal. Author: @sidmuls * feat(provider/aws): ALB Lambda target support Author: @sidmuls * fix(provider/aws): fixing error with tags and targetGroups Author: @sidmuls * fix(provider/aws): fixing error with target group field in function request and response objects Author: @sidmuls * refactor(provider/aws): changes as requested by @ChrisThielen Author: @sidmuls * fix(provider/aws): fixing multiValueHeadersEnabled flag usage in lambda support for AWS Application load balancer Author: @sidmuls
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
…aker#7630) * . * feat(provider/aws): Function listing and searching functionality This change adds a new tab for functions and facilitates listing existing functions and searching functions listed. Corresponding provider specific changes are included in this change for AWS. Authors: @sidmuls and @nabebe * feat(provider/aws): Function listing and searching functionality This change adds a new tab for functions and facilitates listing existing functions and searching functions listed. Corresponding provider specific changes are included in this change for AWS. Authors: @sidmuls and @nabebe * refactor(provider/aws): Converting Function class component into function component. This is a refactoring change as requested by reviewer @caseyhebebrand Author: @sidmuls * refactor(provider/aws): Refactoring groupings into a separate component. This change is for refactoring requested by reviewer @caseyhebebrand. Author: @sidmuls * refactor(provider/aws): Removing unnecessary state from FunctionGroupings. This change is a refactoring requested by @caseyhebebrand Author: @sidmuls * refactor(provider/aws): removing extra line. Tthis is actually for retrying tests on TravisCI * refactor(provider/aws): Adding tests for FunctionFilterService and changes as requested by @christopherthielen Author: @sidmuls * refactor(provider/aws): removing unnecessary field from IFunction * refactor(provider/aws): adding flag to turn off functions feature * feat(provider/aws): Function CREATE EDIT and DELETE feature. Author: @sidmuls and @nabebe * fix(provider/aws): fixing import statement Author: @sidmuls * fix(provider/aws): resolving merge conflicts * fix(provider/aws): fixing property type for Entity Tags Author: @sidmuls * fix(provider/aws): removing unnecessary component from AwsFunctionDetails Author: @sidmuls * refactor(provider/aws): fixing review comments by @caseyhebebrand Author: @sidmuls * refactor(provider/aws): changes for following best practices as requested by @christophertheilen Author: @sidmuls * refactor(provider/aws): Adding message to display in case function is not found in AmazonFunctionDetails.tsx. Author: @sidmuls * refactor(provider/aws): Replacing MapEditor with MapEditorInput in FunctionEnvironmentVariables.tsx Author: @sidmuls * refactor(provider/aws): fixes for comments requested by @christheilen Author: @sidmuls * refactor(provider/aws): changes as requested by @ChrisThielen and a bug fix for filtering and displaying subnet Ids in Network section of functions modal. Author: @sidmuls * feat(provider/aws): ALB Lambda target support Author: @sidmuls * fix(provider/aws): fixing error with tags and targetGroups Author: @sidmuls * fix(provider/aws): fixing error with target group field in function request and response objects Author: @sidmuls * refactor(provider/aws): changes as requested by @ChrisThielen Author: @sidmuls * fix(provider/aws): fixing multiValueHeadersEnabled flag usage in lambda support for AWS Application load balancer Author: @sidmuls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables creating Target group with lambda function as target type.
This change also includes fixes for consistency in
tagsandtargetGroupsfields. in Function definition classes.