Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Judgement Filter #8700

Closed
wants to merge 2 commits into from
Closed

Manual Judgement Filter #8700

wants to merge 2 commits into from

Conversation

rumit-opsmx
Copy link
Contributor

Motivation and Rationale

If there are many pipelines it may be difficult for the user to serially check all the pipelines that are waiting for manual judgement. We need an Easy way to filter for pipelines waiting on Manual Judgment.

If we have a pipeline that is waiting on manual judgement then all the other pipelines that are waiting for this pipeline to be executed will be in the waiting stage. Clicking on any of the waiting stages will directly take you to the pipeline waiting on manual judgment.

Design

  1. Enhanced FilterModelService.ts to

added a filter tag for manual judgment and enhanced the clear filter functionality to clear manual judgment filter.

  1. Enhanced IFilterModel to

added filterStages and stages to ISortFilter

  1. Enhanced Execution.tsx to

added goToParent and manualJudgment to IExecutionProps
added a finalChild function that recursively finds the final child pipeline waiting on manual judgment.

  1. Enhanced ExecutionMarker.tsx to

Added a manual judgment status whether the stage’s child pipeline is waiting on manual Judgment.
Added the functionality so when a stage whose child pipeline is waiting on manual judgment is clicked then it scrolls to the leaf pipeline waiting on the manual judgment.

  1. Enhanced executionMarker.less to

added a visual indicator to the stages waiting on manual judgment.

  1. Enhanced ExecutionGroups.tsx to

added an id to the Execution group level so that we can scroll to the execution group in case the execution group is collapsed.

  1. Enhanced ExecutionGroup.tsx to

added a function to go to root pipeline waiting on manual judgment. if the execution group is collapsed then it will move the focus to the execution group header instead.
created a function to filter all the executions that contain manual judgement
Created a object containing all executions that are waiting on manual judgment and it's immidiate child

  1. Enhanced ExecutionFilterModel.ts to
    added a filterstages property to sortfilter to extend the functionality and to reuse the same object to add other filters to the stages in future.

  2. Enhanced ExecutionFilters.tsx to
    created a new component to be used for stage filter for filtering Manual Judgment filter. it can be reused to add more stage filter in the future.

  3. Enhanced executionFilter.service.ts to

enhance the clearFilters function to clear all the stageFilters also.

  1. Enhanced ProjectPipeline.tsx to

add a default value to support the scroll to leaf if pipeline is waiting on manual judgment functionality.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@rumit-opsmx rumit-opsmx closed this Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants