Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Rationale
If there are many pipelines it may be difficult for the user to serially check all the pipelines that are waiting for manual judgement. We need an Easy way to filter for pipelines waiting on Manual Judgment.
If we have a pipeline that is waiting on manual judgement then all the other pipelines that are waiting for this pipeline to be executed will be in the waiting stage. Clicking on any of the waiting stages will directly take you to the pipeline waiting on manual judgment.
Design
added a filter tag for manual judgment and enhanced the clear filter functionality to clear manual judgment filter.
added filterStages and stages to ISortFilter
added goToParent and manualJudgment to IExecutionProps
added a finalChild function that recursively finds the final child pipeline waiting on manual judgment.
Added a manual judgment status whether the stage’s child pipeline is waiting on manual Judgment.
Added the functionality so when a stage whose child pipeline is waiting on manual judgment is clicked then it scrolls to the leaf pipeline waiting on the manual judgment.
added a visual indicator to the stages waiting on manual judgment.
added an id to the Execution group level so that we can scroll to the execution group in case the execution group is collapsed.
added a function to go to root pipeline waiting on manual judgment. if the execution group is collapsed then it will move the focus to the execution group header instead.
created a function to filter all the executions that contain manual judgement
Created a object containing all executions that are waiting on manual judgment and it's immidiate child
Enhanced ExecutionFilterModel.ts to
added a filterstages property to sortfilter to extend the functionality and to reuse the same object to add other filters to the stages in future.
Enhanced ExecutionFilters.tsx to
created a new component to be used for stage filter for filtering Manual Judgment filter. it can be reused to add more stage filter in the future.
Enhanced executionFilter.service.ts to
enhance the clearFilters function to clear all the stageFilters also.
add a default value to support the scroll to leaf if pipeline is waiting on manual judgment functionality.