Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jenkins): Enable properties and artifacts with job name as query parameter #1393

Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix(jenkins): Enable properties and artifacts with job name as query parameter #1393

merged 2 commits into from
Feb 27, 2024

Conversation

christosarvanitis
Copy link
Member

@christosarvanitis christosarvanitis commented Feb 26, 2024 •
edited
Loading

Fixes spinnaker/spinnaker#6928

The implementation of:

        feature:
          igor:
            jobNameAsQueryParameter: true

did not include the support for Jenkins artifacts and property files leading to failures on Manual triggers and rerun's of a Spinnaker pipeline retrieving BuildInfo from the sub-folder Jenkins job.

@christosarvanitis christosarvanitis marked this pull request as ready for review February 26, 2024 13:34
@ovidiupopa07 ovidiupopa07 added the ready to merge Approved and ready for merge label Feb 27, 2024
@mergify mergify bot added the auto merged label Feb 27, 2024
@mergify mergify bot merged commit 44317c1 into spinnaker:master Feb 27, 2024
4 checks passed
@ovidiupopa07
Copy link
Contributor

ovidiupopa07 commented Feb 27, 2024 •
edited
Loading

@Mergifyio backport release-1.33.x release-1.32.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 27, 2024 •
edited
Loading

backport release-1.33.x release-1.32.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 27, 2024
@christosarvanitis @mergify
fix(jenkins): Enable properties and artifacts with job name as query …
c944450 
…parameter (#1393)

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 44317c1)
@mergify mergify bot mentioned this pull request Feb 27, 2024
Merged
mergify bot pushed a commit that referenced this pull request Feb 27, 2024
@christosarvanitis @mergify
fix(jenkins): Enable properties and artifacts with job name as query …
eace12b 
…parameter (#1393)

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 44317c1)
@mergify mergify bot mentioned this pull request Feb 27, 2024
Merged
mergify bot added a commit that referenced this pull request Feb 27, 2024
@mergify @christosarvanitis
fix(jenkins): Enable properties and artifacts with job name as query …
abce091 
…parameter (#1393) (#1395)

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 44317c1)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
mergify bot added a commit that referenced this pull request Feb 27, 2024
@mergify @christosarvanitis
fix(jenkins): Enable properties and artifacts with job name as query …
d5ebde4 
…parameter (#1393) (#1396)

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 44317c1)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
@jasonmcintosh
Copy link
Member

https://github.com/Mergifyio backport release-1.31.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 14, 2024 •
edited
Loading

backport release-1.31.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 14, 2024
@christosarvanitis @mergify
fix(jenkins): Enable properties and artifacts with job name as query …
c639b6d 
…parameter (#1393)

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 44317c1)
@mergify mergify bot mentioned this pull request Mar 14, 2024
Merged
mergify bot added a commit that referenced this pull request Mar 14, 2024
@mergify @christosarvanitis
fix(jenkins): Enable properties and artifacts with job name as query …
1486874 
…parameter (#1393) (#1403)

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 44317c1)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovidiupopa07 ovidiupopa07 ovidiupopa07 approved these changes

@jasonmcintosh jasonmcintosh jasonmcintosh approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.34
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manual execution fails to retrieve propertyFile/Artifacts from Jenkins multibranch/sub-folder jobs
4 participants
@christosarvanitis @ovidiupopa07 @jasonmcintosh @spinnakerbot