fix(pubsub): Restart Google Pubsub subscriber on failures #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjoel
force-pushed
the
restart-pubsub-on-failure
branch
from
b94978c to
cebc471
Compare
lwander
approved these changes
May 22, 2018
| return new GooglePubsubSubscriber(subscription.getName(), subscriptionName, project, subscriber); | ||
| subscriber.addListener(new GooglePubsubFailureHandler(this, formatSubscriptionName(project, subscriptionName)), MoreExecutors.directExecutor()); | ||
| subscriber.startAsync().awaitRunning(); | ||
| log.info("Google Pubsub subscriber started"); |
There was a problem hiding this comment.
Can we add the subscription & project name to this log message?
ezimanyi
approved these changes
May 22, 2018
jtk54
reviewed
May 22, 2018
| } | ||
|
|
||
| private void restart() { | ||
| log.info("Waiting to restart Google Pubsub subscriber"); |
There was a problem hiding this comment.
Can we add more context to this log statement as well?
| @@ -81,7 +85,7 @@ public String subscriptionName() { | |||
|
|
|||
| @Override | |||
| public String getName() { | |||
| return name; | |||
| return subscriptionName; | |||
There was a problem hiding this comment.
We made a distinction between the subscriptionName, which is the actual locator in GCE and the logical name which is used in the UI when suggesting pub/sub subscriptions to use. Is there a reason to change that here?
wjoel
force-pushed
the
restart-pubsub-on-failure
branch
from
cebc471 to
50ab8d0
Compare
|
@jtk54 That makes sense, I'll leave |
|
Great, thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new
Subscriberon failures, as according to googleapis/google-cloud-java#1579 (comment) we can"restart" the Subscriber by creating a new Subscriber object.I've also removed
.setMaxAckExtensionPeriod(Duration.ofSeconds(0))as googleapis/google-cloud-java#2465 (comment) recommends against it.Potentially solves spinnaker/spinnaker#2762 but needs more testing. I've verified that echo resumes consuming pubsub messages after I removed its
Pub/Sub Subscriberpermission (took a little while before it noticed) and then added it back again.