Skip to content

Commit

Permalink
fix(dependency): Issue with jackson-bom and kotlin-bom version confli…
Browse files Browse the repository at this point in the history
…ct resolution while upgrading the spring-boot 2.3.x (#923)

The root cause of this issue is uncontrolled conflict resolution of jackson-bom and kotlin-bom dependency version imported from external maven BOM provided by kork-bom, as per the gradle documentation here (https://docs.gradle.org/6.9.1/userguide/platforms.html#sub:bom_import), we can use gradle enforcedPlatform closure as part of the implementation to strictly adhere the versions of direct and transitive dependencies imported BOM. This approach could be considered as optimally feasible fix for this issue. And for upcoming upgrades and developments, it will also ensure the predictable dependency imports from kork-bom.

Similar issue has been encountered while upgrading spring-boot to 2.3.x for gate service, for detailed discussion please refer to:
spinnaker/gate#1505

This fix is seamless for the existing code.
  • Loading branch information
j-sandy authored Mar 10, 2022
1 parent 9bbea68 commit ca45708
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ subprojects {
}

dependencies {
implementation platform("io.spinnaker.kork:kork-bom:$korkVersion")
implementation enforcedPlatform("io.spinnaker.kork:kork-bom:$korkVersion")
compileOnly "org.projectlombok:lombok"
annotationProcessor platform("io.spinnaker.kork:kork-bom:$korkVersion")
annotationProcessor "org.projectlombok:lombok"
Expand Down

0 comments on commit ca45708

Please sign in to comment.