fix(ldap/roles): fix the issue of multiple entries in Ldap for single user #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Jul 19, 2024
...-ldap/src/test/groovy/com/netflix/spinnaker/fiat/roles/ldap/LdapUserRolesProviderTest.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jul 19, 2024
...-ldap/src/test/groovy/com/netflix/spinnaker/fiat/roles/ldap/LdapUserRolesProviderTest.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jul 19, 2024
...-ldap/src/test/groovy/com/netflix/spinnaker/fiat/roles/ldap/LdapUserRolesProviderTest.groovy
Outdated
Show resolved
Hide resolved
kirangodishala
force-pushed
the
handle-multiple-ldap-entries
branch
4 times, most recently
from
689ed86 to
7dd040c
Compare
dbyron-sf
reviewed
Jul 31, 2024
...-ldap/src/test/groovy/com/netflix/spinnaker/fiat/roles/ldap/LdapUserRolesProviderTest.groovy
Show resolved
Hide resolved
kirangodishala
force-pushed
the
handle-multiple-ldap-entries
branch
from
7dd040c to
95b0b9e
Compare
…xist for a user id.
… user * update tests as per the new code changes
dbyron-sf
force-pushed
the
handle-multiple-ldap-entries
branch
from
95b0b9e to
7ac5388
Compare
dbyron-sf
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been observed that when a user has multiple entries in LDAP the resulting roles set for that user is empty.
This PR addresses the issue by merging the unique roles associated with all the entries for that user.
Before adding the changes, I have updated the existing tests to strengthen the assertions and included a test demonstrating the issue.