-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add account manager roles config #928
Conversation
Is this an "on/off" kinda role? i.e. does having an account management role allow you to manipulate all accounts, or only those for which you have WRITE permission on for example? edit: I see from the Gate PR you need WRITE to update an account once it's created. Is there scope for more granularity on this account management role? I think I'm correct in saying this role is just a base level check in front of the WRITE permission check. Like an account management admin, who can manipulate all accounts, even if they don't have WRITE? |
This is in addition to the write permissions specified. Basically, instead of allowing all authenticated users to use the API, this allows for limiting that. Permissions are still otherwise enforced by the permissions specified in the account definition. |
fiat-roles/src/main/java/com/netflix/spinnaker/fiat/permissions/DefaultPermissionsResolver.java
Outdated
Show resolved
Hide resolved
This adds a Fiat configuration option for the Account Management API in Clouddriver for listing which roles are allowed to manage accounts in the API.
e854794
to
1765f9c
Compare
@Mergifyio update |
✅ Branch has been successfully updated |
This adds a Fiat configuration option for the Account Management API in Clouddriver for listing which roles are allowed to manage accounts in the API.
This option was requested during the initial phase of development for the API. We'll need a Fiat release cut in order to use the changes in Clouddriver, however.