feat(pipeline executions/front50) : Added code to save multiple pipelines at once to sql database. #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robzienert @ajordens ....Can you please review this PR |
…ines at once to sql db. This is part of: spinnaker/spinnaker#6147. Enhanced PipelineController.java to Added new rest api method bulksave(List<Map> pipelineList, Boolean staleCheck) This method accepts a list of pipelines json. This method checks each and every pipeline for authorization. If the pipeline has valid authorization, then it will be saved to a savedPipelineList. If the pipeline do not have a valid authorization, then it will be saved to a errorPipelineList and an error message is also populated. All the savedPipelinesList will be saved to sql database using bulk insert. This method returns a Map object having the below data: { “Successful”: <count>, “Failed”: <cound>, “Failed_list”: [<array of failed pipelines - (application, pipeline name, etc) and the error message] } Enhanced AuthorizationSupport.java to Added code to accept the pipeline list and authorize the pipelines. Enhanced PipelineControllerSpec.java to Added bean of FiatPermissionEvalutor.java as it is used in the PipelineController constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(pipeline executions/front50) : Added code to save multiple pipelines at once to sql database.
This is part of: spinnaker/spinnaker#6147.
Enhanced PipelineController.java to
Added new rest api method bulksave(List pipelineList, Boolean staleCheck)
This method accepts a list of pipelines json.
This method checks each and every pipeline for authorization.
If the pipeline has valid authorization, then it will be saved to a savedPipelineList.
If the pipeline do not have a valid authorization, then it will be saved to a errorPipelineList
and an error message is also populated.
All the savedPipelinesList will be saved to sql database using bulk insert.
This method returns a Map object having the below data:
{
“Successful”: ,
“Failed”: ,
“Failed_list”: [<array of failed pipelines - (application, pipeline name, etc) and the error message]
}
Enhanced AuthorizationSupport.java to
Added code to accept the pipeline list and authorize the pipelines.
Enhanced PipelineControllerSpec.java to
Added bean of FiatPermissionEvalutor.java as it is used in the PipelineController constructor.
Enhanced PipelineControllerTck.groovy to
Added bean of FiatPermissionEvalutor.java as it is used in the PipelineController constructor.