Skip to content

Commit

Permalink
fix(dependency): Introducing spring dependency management gradle plugin
Browse files Browse the repository at this point in the history
Spring boot has moved to gradle based dependency management from v2.3.x. This change has brought issue of conflict resolution failure of the Jackson-bom version and kotlin-bom version with gate service when it consumes the maven-bom generated by kork. The issue details are available in given link.
https://docs.google.com/document/d/1Ck4KeoB1ER0aQUTnf3e-x-M3i2Ur0It7YaaxEMiMXls/edit

To resolve this issue while upgrading gate service with spring v2.3.x, we must require the spring dependency management gradle plugin.
  • Loading branch information
j-sandy committed Jan 17, 2022
1 parent 11d7ce6 commit b3b2c9e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
8 changes: 8 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@ plugins {
id "org.jetbrains.kotlin.jvm" version "$kotlinVersion" apply false
id "org.jetbrains.kotlin.plugin.allopen" version "$kotlinVersion" apply false
id "org.jetbrains.dokka" version "0.10.1" apply false
id "io.spring.dependency-management" version "$springDependencyPluginVersion"
}

allprojects {
apply plugin: 'io.spinnaker.project'
apply plugin: "io.spring.dependency-management"

group = "io.spinnaker.gate"

Expand Down Expand Up @@ -46,6 +48,12 @@ allprojects {
testRuntimeOnly "org.objenesis:objenesis"
}

dependencyManagement {
imports {
mavenBom "io.spinnaker.kork:kork-bom:$korkVersion"
}
}

configurations.all {
exclude group: 'javax.servlet', module: 'servlet-api'
exclude group: 'javax.servlet', module: 'javax.servlet-api'
Expand Down
1 change: 1 addition & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ korkVersion=7.131.0
kotlinVersion=1.4.0
org.gradle.parallel=true
spinnakerGradleVersion=8.16.0
springDependencyPluginVersion=1.0.11.RELEASE
targetJava11=true

# To enable a composite reference to a project, set the
Expand Down

0 comments on commit b3b2c9e

Please sign in to comment.