perf(web): Query for individual pipelines #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ineConfig and use pipeline name instead of id in InvokePipelineConfigTest to reduce diffs when ApplicationService.getPipelineConfigForApplication changes the queries it makes to front50
…to query front50 for individual pipelines instead of querying for all pipelines in an application and then filtering locally.
…on to handle errors with SpinnakerRetrofitErrorHandler to centralize exception handling there / remove the need for callers to check for null
dbyron-sf
approved these changes
Sep 30, 2024
dbyron-sf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust error message in PipelineController.invokePipelineConfig and use pipeline name instead of id in InvokePipelineConfigTest to reduce diffs when ApplicationService.getPipelineConfigForApplication changes the queries it makes to front50
Change ApplicationService.getPipelineConfigForApplication to query front50 for individual pipelines instead of querying for all pipelines in an application and then filtering locally.
Teach ApplicationService.getPipelineConfigForApplication to handle errors with SpinnakerRetrofitErrorHandler to centralize exception handling there / remove the need for callers to check for null