chore(build): target Java 17 bytecode #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Nov 7, 2024
| @@ -2,7 +2,7 @@ fiatVersion=1.50.0 | |||
| korkVersion=7.243.0 | |||
| org.gradle.parallel=true | |||
| spinnakerGradleVersion=8.32.1 | |||
| targetJava17=false | |||
| targetJava17=true | |||
There was a problem hiding this comment.
Is it also time to remove the java 11 docker images?
There was a problem hiding this comment.
Plus also, do we still need -PenableCrossCompilerPlugin=true in the gradle invocations?
There was a problem hiding this comment.
I reckon we go live with this small change in Igor, and if we're happy we come back and purge Java 11 from existence a few weeks after release.
Then for other repos just switch/purge at the same time.
There was a problem hiding this comment.
OK, let's do it. This'll make it into 1.36....
dbyron-sf
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the build to target Java 17 bytecode when building.
cc @dbyron-sf