Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(influxdb): enhancements and bug fixes #899

Merged
merged 13 commits into from
Oct 11, 2022

Conversation

ichiong
Copy link
Contributor

@ichiong ichiong commented Jul 21, 2022

Summary of changes:

  • adding indluxdb docs to guide users on how to use this plugin: metric-set-query-config.md
  • changes to InfluxDbResponseConverter.java is to fix kayenta-influxdb plugin when it returns or throws an error if the result that we got from influx contains values that are of type float or double.
    • example error that we get: class java.lang.Double cannot be cast to class java.lang.Integer (java.lang.Double and java.lang.Integer are in module java.base of loader 'bootstrap'.
    • The InfluxDbResponseConverterTest.java contains unit tests for these changes.
  • changes to InfluxDbMetricsService.java is to fix situations when an influx query returns no results:

kayenta_error

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@ichiong ichiong changed the title feat: influxdb enhancements and bug fixes feat(influxdb): enhancements and bug fixes Jul 21, 2022
IvanessChristleChiong and others added 7 commits July 21, 2022 13:18
This change makes the project compatible with Gradle 7
…dation-api (spinnaker#897)

since spring cloud Hoxton.SR12 doesn't bring it in.  See
spinnaker/orca#4254 for more.
Co-authored-by: root <root@470565d33c7a>
Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
@ichiong ichiong force-pushed the influxdb_enhancements branch from fb0f1fb to e342c16 Compare July 21, 2022 18:19
@ichiong ichiong marked this pull request as ready for review July 21, 2022 20:14
blocked.add("SHOW SHARD");
blocked.add("SHOW STATS");
blocked.add("SHOW SUBSCRIPTIONS");
blocked.add(";"); // prevents having multiple queries that could lead to potential sql injection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I DO wonder if there's a regex/cleaner way to catch these kinda things...

@fieldju fieldju merged commit a3c9ae7 into spinnaker:master Oct 11, 2022
@fieldju
Copy link
Collaborator

fieldju commented Oct 11, 2022

Brings tears to my eyes seeing that UI and Logo!

@ichiong ichiong deleted the influxdb_enhancements branch October 18, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants