chore(dependencies): Upgrade Spring Boot to 2.2.13 #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
dbyron-sf
reviewed
Sep 23, 2021
j-sandy
force-pushed
the
sb-upgrade-2-2-13
branch
2 times, most recently
from
00c9ae9 to
92e40be
Compare
j-sandy
force-pushed
the
sb-upgrade-2-2-13
branch
from
92e40be to
8cf9112
Compare
j-sandy
pushed a commit
to j-sandy/rosco
that referenced
this pull request
Sep 27, 2021
Refer spinnaker/spinnaker#6537 During verification of spring boot upgrade using spinnaker/kork#895, received below error: Task :rosco-core:compileTestGroovy startup failed: /rosco/rosco-core/src/test/groovy/com/netflix/spinnaker/rosco/providers/CloudProviderBakeHandlerSpec.groovy: 69: Only @shared and static fields may be accessed from here @ line 69, column 7. SOME_BAKE_REQUEST | SOME_BAKE_RECIPE | SOME_BAKE_RECIPE_NAME | null | SOME_AMI_ID | SOME_BUILD_INFO_URL | SOME_BUILD_NR ^ /rosco/rosco-core/src/test/groovy/com/netflix/spinnaker/rosco/providers/CloudProviderBakeHandlerSpec.groovy: 68: Only @shared and static fields may be accessed from here @ line 68, column 27. null | SOME_BAKE_RECIPE | SOME_BAKE_RECIPE_NAME | null | SOME_AMI_ID | null | null ^ /rosco/rosco-core/src/test/groovy/com/netflix/spinnaker/rosco/providers/CloudProviderBakeHandlerSpec.groovy: 69: Only @shared and static fields may be accessed from here @ line 69, column 27. SOME_BAKE_REQUEST | SOME_BAKE_RECIPE | SOME_BAKE_RECIPE_NAME | null | SOME_AMI_ID | SOME_BUILD_INFO_URL | SOME_BUILD_NR ^ To fix the error, added @shared in TestDefaults.groovy file.
mergify bot
pushed a commit
to spinnaker/rosco
that referenced
this pull request
Sep 27, 2021
Refer spinnaker/spinnaker#6537 During verification of spring boot upgrade using spinnaker/kork#895, received below error: Task :rosco-core:compileTestGroovy startup failed: /rosco/rosco-core/src/test/groovy/com/netflix/spinnaker/rosco/providers/CloudProviderBakeHandlerSpec.groovy: 69: Only @shared and static fields may be accessed from here @ line 69, column 7. SOME_BAKE_REQUEST | SOME_BAKE_RECIPE | SOME_BAKE_RECIPE_NAME | null | SOME_AMI_ID | SOME_BUILD_INFO_URL | SOME_BUILD_NR ^ /rosco/rosco-core/src/test/groovy/com/netflix/spinnaker/rosco/providers/CloudProviderBakeHandlerSpec.groovy: 68: Only @shared and static fields may be accessed from here @ line 68, column 27. null | SOME_BAKE_RECIPE | SOME_BAKE_RECIPE_NAME | null | SOME_AMI_ID | null | null ^ /rosco/rosco-core/src/test/groovy/com/netflix/spinnaker/rosco/providers/CloudProviderBakeHandlerSpec.groovy: 69: Only @shared and static fields may be accessed from here @ line 69, column 27. SOME_BAKE_REQUEST | SOME_BAKE_RECIPE | SOME_BAKE_RECIPE_NAME | null | SOME_AMI_ID | SOME_BUILD_INFO_URL | SOME_BUILD_NR ^ To fix the error, added @shared in TestDefaults.groovy file. Co-authored-by: j-sandy <jsandy>
dbyron-sf
approved these changes
Sep 27, 2021
6 tasks
ylebedeva
pushed a commit
to ylebedeva/kork
that referenced
this pull request
May 3, 2022
Co-authored-by: j-sandy <jsandy>
ylebedeva
pushed a commit
to ylebedeva/kork
that referenced
this pull request
May 24, 2022
Co-authored-by: j-sandy <jsandy>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of spinnaker/spinnaker#6537
Upgrade spring boot from 2.2.5 to 2.2.13.
Along with it upgrade org.junit:junit-bom to 5.6.3. due to this:
spring boot 2.2.13 uses groovy version 2.5.14, that upgrades org.codehaus.groovy:groovy-test from 2.5.11 (constrained in spinnaker-dependencies) to 2.5.14 and upgrades junit:junit from 4.13 to 4.13.1.
In kork, org.junit:junit-bom is constrained to 5.6.2, having bug as junit-vintage-engine:5.6.2 does not parse junit version of format x.y.z, just parse x.y.
This bug is fixed in 5.6.3 and 5.7.0.
junit-team/junit5#2529
junit-team/junit5#2198