chore(queue): Delete unmaintained hydrate command #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I learned about it from https://spinnaker.io/guides/runbooks/orca-zombie-executions/#rehydrate-the-queue. |
|
Thanks! I'll need to delete that section from the docs as well. |
|
Related: spinnaker/spinnaker.github.io#2075 |
| @@ -40,7 +40,7 @@ import org.springframework.stereotype.Component | |||
| @ConditionalOnExpression( | |||
| "\${queue.zombie-check.enabled:false}" | |||
| ) | |||
| @ConditionalOnBean(MonitorableQueue::class) | |||
| @ConditionalOnBean(ZombieExecutionService::class) | |||
There was a problem hiding this comment.
i think you still need the conditional on queue since it's used by this class?
marchello2000
approved these changes
Oct 22, 2020
robzienert
force-pushed
the
delete-hydrate
branch
from
c252ffd
to
9a3e485
Compare
|
Still trying to figure out why tests are failing in github, but not locally... |
robzienert
force-pushed
the
delete-hydrate
branch
from
9a3e485
to
8f09f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code never truly worked. Apparently someone in OSS found it and tried to run it.