feat(stages): Add SpEL expression for converting canary config name to id. #4030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o id. Add javadocs. Add javadocs. feat(stages): Update canManuallySkip to look at stage context and override it on the PipelineStage to enable pipeline stages to be skippable.
haleyw
requested review from
dwest-netflix,
robzienert and
anotherchrisberry
.../com/netflix/spinnaker/orca/kayenta/pipeline/functions/ConfigExpressionFunctionProvider.java
Outdated
Show resolved
Hide resolved
dwest-netflix
approved these changes
Dec 15, 2020
robzienert
reviewed
Dec 15, 2020
.../com/netflix/spinnaker/orca/kayenta/pipeline/functions/ConfigExpressionFunctionProvider.java
Outdated
Show resolved
Hide resolved
.../com/netflix/spinnaker/orca/kayenta/pipeline/functions/ConfigExpressionFunctionProvider.java
Outdated
Show resolved
Hide resolved
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
…o id. (spinnaker#4030) * feat(stages): Add SpEL expression for converting canary config name to id. Add javadocs. Add javadocs. feat(stages): Update canManuallySkip to look at stage context and override it on the PipelineStage to enable pipeline stages to be skippable. * Address NIT's from code review feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a SpEL expression which will take a canary config name and convert it to an ID.
I have written unit tests for this, but haven't tested it end-to-end yet (mostly because I'm not sure how?). Please let me know if there is more you would recommend testing at this point.