Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipelineTriggers): change buildNumber type from int to string #4316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaredstehler
Copy link
Contributor

in order to support build numbers which are not strict integers (i.e. "123.1")

spinnaker/spinnaker#6743

@dbyron-sf
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2022

update

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@wn-doolittle needs to authorize modification on its head branch.
err-code: C7190

@@ -112,7 +112,9 @@ public boolean tryToExtractBuildDetails(BuildInfo<?> buildInfo, Map<String, Obje
if (buildInfo == null || request == null) {
return false;
}
if (buildInfo.getUrl() != null && buildInfo.getName() != null && buildInfo.getNumber() > 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaah, here's the place that was treating a number <= 0 as missing...

in order to support build numbers which are not strict integers (i.e. "123.1")
@jaredstehler jaredstehler force-pushed the build-number-tostring branch from 90975c0 to c3eb632 Compare February 9, 2023 16:10
@jaredstehler
Copy link
Contributor Author

can this be merged yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants