fix(front50): teach MonitorPipelineTask to handle missing/null execution ids #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion ids give the task terminal status in this case since that feels closer to the truth than succeeded even though the error is likely elsewhere (e.g. in a StartPipelineTask).
dbyron-sf
force-pushed
the
MonitorPipelineTask-nonexistent-execution-id
branch
from
5e04c9b to
dc4c681
Compare
nemesisOsorio
approved these changes
Oct 9, 2023
edgarulg
approved these changes
Oct 9, 2023
6 tasks
|
@Mergifyio backport release-1.28.x release-1.29.x release-1.30.x release-1.32.x |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Oct 9, 2023
…ion ids (#4555) (#4556) give the task terminal status in this case since that feels closer to the truth than succeeded even though the error is likely elsewhere (e.g. in a StartPipelineTask). (cherry picked from commit 7523f5d) Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Oct 9, 2023
…ion ids (#4555) (#4557) give the task terminal status in this case since that feels closer to the truth than succeeded even though the error is likely elsewhere (e.g. in a StartPipelineTask). (cherry picked from commit 7523f5d) Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Oct 9, 2023
…ion ids (#4555) (#4558) give the task terminal status in this case since that feels closer to the truth than succeeded even though the error is likely elsewhere (e.g. in a StartPipelineTask). (cherry picked from commit 7523f5d) Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Oct 9, 2023
…ion ids (#4555) (#4559) give the task terminal status in this case since that feels closer to the truth than succeeded even though the error is likely elsewhere (e.g. in a StartPipelineTask). (cherry picked from commit 7523f5d) Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
|
@dbyron-sf seems like you miss backport for |
|
@Mergifyio backport release-1.27.x release-1.31.x |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Oct 10, 2023
…ion ids (#4555) (#4561) give the task terminal status in this case since that feels closer to the truth than succeeded even though the error is likely elsewhere (e.g. in a StartPipelineTask). (cherry picked from commit 7523f5d) Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Oct 10, 2023
…ion ids (#4555) (#4560) give the task terminal status in this case since that feels closer to the truth than succeeded even though the error is likely elsewhere (e.g. in a StartPipelineTask). (cherry picked from commit 7523f5d) Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
give the task terminal status in this case since that feels closer to the truth than succeeded even though the error is likely elsewhere (e.g. in a StartPipelineTask).