Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(java17): use JRE17, run tests on JRE17, compile with JDK11 #4604

Merged
merged 1 commit into from
Nov 24, 2023
Merged

feat(java17): use JRE17, run tests on JRE17, compile with JDK11 #4604

merged 1 commit into from
Nov 24, 2023

Conversation

mattgogerly
Copy link
Member

Number 5 on our Java 17 adventure.

See also spinnaker/front50#1274, spinnaker/igor#1143 etc

@mattgogerly
Copy link
Member Author

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2023

update

✅ Branch has been successfully updated

@mattgogerly
Copy link
Member Author

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2023

update

✅ Branch has been successfully updated

@mattgogerly mattgogerly marked this pull request as ready for review November 22, 2023 16:47
@mattgogerly mattgogerly mentioned this pull request Nov 22, 2023
Merged
dbyron-sf
dbyron-sf reviewed Nov 22, 2023
View reviewed changes
gradle.properties Outdated Show resolved Hide resolved
dbyron-sf
dbyron-sf approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@dbyron-sf dbyron-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, but approved. Pretty sure buildtool needs an update too.

@mattgogerly mattgogerly added the ready to merge Approved and ready for merge label Nov 24, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Nov 24, 2023
@mergify mergify bot merged commit 6118137 into spinnaker:master Nov 24, 2023
5 checks passed
@mattgogerly mattgogerly deleted the feat/jre17 branch November 24, 2023 19:27
This was referenced Nov 28, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.33
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattgogerly @dbyron-sf @spinnakerbot