fix(oauth2): ensure refresh token exists before using expired credential #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmakersteve
changed the title
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
webmakersteve
force-pushed
the
date-check
branch
from
99a451f to
d43e0a9
Compare
|
thanks for adding this, it was badly needed for awhile 🙌 |
|
No problem! Already using the binary built off of this commit locally so I could get around the issue myself! :) |
|
How do we get this merged into the repo @Chinikins ? |
Chinikins
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue using an identity provider which did not issue refresh tokens.
Currently the command line tool will fail to authenticate with OAuth2 if using an expired access token and the refresh token is not set. This PR adjusts it to clear the cached credentials if it is expired and there is no refresh token set. The tool will then run the auth routine from the beginning, allowing you to re-log in rather than requiring you edit the spin config file to move forward.