chore(lint): Bump GitHub Action versions #358
Conversation
Lint action failing and various actions could be bumped which might help.
karlskewes
force-pushed
the
golangci-lint
branch
2 times, most recently
from
5480625
to
cc805e8
Compare
| - uses: actions/setup-go@v4 | ||
| with: | ||
| go-version-file: go.mod | ||
| cache: false |
There was a problem hiding this comment.
It would be good to investigate caching options:
| @@ -0,0 +1,7 @@ | |||
| version: 2 | |||
There was a problem hiding this comment.
This has worked well for me in other non-spinnaker repositories.
Be good to add to all of the repositories.
Weekly interval might generate a lot of PR's (especially across all repositories).
See: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#scheduleinterval
There was a problem hiding this comment.
Let's try it :). If it works, it'll be nice to use elsewhere.
| uses: actions/checkout@v3 | ||
| - uses: actions/setup-go@v4 | ||
| with: | ||
| go-version-file: go.mod |
There was a problem hiding this comment.
No need to manually bump the Go version in GHA's anymore.
setup-go can now pull from go.mod which is the source of truth.
Works well for me in other non-spinnaker repositories.
| @@ -27,17 +31,18 @@ jobs: | |||
| if: startsWith(github.repository, 'spinnaker/') | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
Somehow it feels funny to do checkout + setup-go twice. I'm inclined to merge this and follow up with improvements to unblock the other open PRs.
Lint action was failing. Bumping versions for various actions seems to fix it.