Skip to content
This repository has been archived by the owner on Aug 2, 2019. It is now read-only.

Add geometry field types #30

Closed
leplatrem opened this issue Dec 5, 2012 · 6 comments
Closed

Add geometry field types #30

leplatrem opened this issue Dec 5, 2012 · 6 comments
Assignees

Comments

@leplatrem
Copy link
Contributor

  • Point
  • Line
  • Polygon
  • Posted values will be coordinates list, like those stored in GeoJSON format
  • Will be rendered as GeoJSON individually
  • Collection of records will be rendered as GeoJSON only once issue Records formatting #12 is implemented
@leplatrem
Copy link
Contributor Author

Remains to be done :

  • A point should not be a colander.Sequence but a PointNode
  • Make use for colander.Range validators for GPS coordinates
  • Add check on LinearRing for polygons (last coordinate must be equal to first one).
  • Add holes for polygons (list of _LinearRing_s : first is exterior, following are holes)

@leplatrem
Copy link
Contributor Author

Done !

Would be glad if someone could review code and docstrings please !

@almet
Copy link
Member

almet commented Dec 7, 2012

commented there. I think a pull request would have been more appropriate, however.

@almet
Copy link
Member

almet commented Dec 7, 2012

Overall, I like it! We should probably put all that in a separate module (.geo ?) like you proposed.
Also add some functional tests for it.

@leplatrem
Copy link
Contributor Author

Code review is not very convenient on Github indeed... But since I'm a "repo collab", a branch is appropriate isn't it ?

Regarding the separate module, shall I make schemas a package then ?

We can discuss here :

  • the meaning and naming of that gps parameter instead of there
  • the proper approach for unit testing deserializations. Actually I globally followed the way colander does it

@almet
Copy link
Member

almet commented Dec 8, 2012

you can push a branch like you did and then issue a pullk request from this branch to master. that allows us to comment the overall diff.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants