This repository has been archived by the owner on Aug 2, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Add geometry field types #30
Labels
Comments
ghost
assigned leplatrem
Dec 5, 2012
leplatrem
added a commit
that referenced
this issue
Dec 5, 2012
leplatrem
added a commit
that referenced
this issue
Dec 5, 2012
leplatrem
added a commit
that referenced
this issue
Dec 6, 2012
Remains to be done :
|
leplatrem
added a commit
that referenced
this issue
Dec 7, 2012
leplatrem
added a commit
that referenced
this issue
Dec 7, 2012
leplatrem
added a commit
that referenced
this issue
Dec 7, 2012
leplatrem
added a commit
that referenced
this issue
Dec 7, 2012
Done ! Would be glad if someone could review code and docstrings please ! |
commented there. I think a pull request would have been more appropriate, however. |
Overall, I like it! We should probably put all that in a separate module (.geo ?) like you proposed. |
Code review is not very convenient on Github indeed... But since I'm a "repo collab", a branch is appropriate isn't it ? Regarding the separate module, shall I make We can discuss here :
|
you can push a branch like you did and then issue a pullk request from this branch to master. that allows us to comment the overall diff. |
leplatrem
added a commit
that referenced
this issue
Dec 8, 2012
leplatrem
added a commit
that referenced
this issue
Dec 8, 2012
leplatrem
added a commit
that referenced
this issue
Dec 9, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: