Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 6.2.0 release #1256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prepare 6.2.0 release #1256

wants to merge 1 commit into from

Conversation

zorun
Copy link
Collaborator

@zorun zorun commented Nov 11, 2023

I would like to release 6.1.2, mostly because of the fix for generate_password_hash.

I will add an entry about #1244 once it's fixed.

According to our new repository rules it needs another maintainer approval or a delay of one week.

CHANGELOG.md Outdated
@@ -4,8 +4,10 @@ This document describes changes between each past release.

## 6.1.2 (unreleased)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving from setup.cfg to pyproject.toml should probably be considered a breaking change. I agree with a previous comment of yours (where you told it would be better to not do things in this order and issue the quick fix first), but it's also probably too late now.

To me, it's at least a new feature (so updating the minor, to 6.2.0), but probably a breaking change, so we should update the major (7.0.0)

@zorun
Copy link
Collaborator Author

zorun commented Nov 18, 2023

I agree we are in an annoying situation, with both a "bugfix" and a "feature" release in sight.

I suggest an alternative route:

@almet what do you think of this plan? If you agree, I can do the backport release this week-end or next week.

@azmeuk
Copy link
Contributor

azmeuk commented Nov 18, 2023

let's plan a 6.2.0 release with existing packaging changes + python 3.12 support, and maybe also #1258 (ping @azmeuk , does it make sense to release all packaging changes together?)

Maybe this worth waiting on #1258 as this is also a big change? I will try to move this forward in the weekend

but in the meantime, let's release a backport 6.1.2 release with just the bugfix from #1242. We've done this in the past, we still have the stable-4.1 branch as an example.

Sounds reasonable to me.

@almet
Copy link
Member

almet commented Nov 18, 2023

That sounds like a plan :-)

  1. Release a backport release
  2. Wait for move from setuptools to hatch #1258 and then issue a new minor release (according to semver, as it's rectrocompatible with the previous packaging tools, a minor is okay).

@zorun
Copy link
Collaborator Author

zorun commented Nov 19, 2023

Great :) I've just released 6.1.2 and backported changelog and CI changes in #1266

I'll update this merge request accordingly.

@zorun zorun changed the title Prepare 6.1.2 release Prepare 6.2.0 release Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants