Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow phpunit 11 in composer json #77

Draft
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Draft

allow phpunit 11 in composer json #77

wants to merge 2 commits into from

Conversation

gam6itko
Copy link
Contributor

No description provided.

@roxblnfk
Copy link
Member

I'm not sure that will work because there the runTest() method is final:
https://github.com/sebastianbergmann/phpunit/blob/9b98888a90c39dc922f01e6d3a34bc077bac3460/src/Framework/TestCase.php#L1095

But we extend it in our test case:

testing/src/TestCase.php

Line 231 in 767e903

protected function runTest(): mixed

Until PHPUnit becomes extensible or interceptors are added, we likely won't be able to upgrade to version 11. If you know how we can intercept test execution in another way, please let us know.

BTW, related issue: sebastianbergmann/phpunit#5254

@roxblnfk roxblnfk marked this pull request as draft December 14, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butschster butschster butschster approved these changes

@roxblnfk roxblnfk Awaiting requested review from roxblnfk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gam6itko @roxblnfk @butschster