Initial Vortex Layouts #1805
Merged
Initial Vortex Layouts #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebasedming
reviewed
Jan 3, 2025
| #[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord)] | ||
| pub struct SegmentId(u32); | ||
|
|
||
| impl From<u32> for SegmentId { |
There was a problem hiding this comment.
For the curiosity of someone unfamiliar with the Vortex code base...how is a Segment defined? What is the relationship between a segment and a chunk?
There was a problem hiding this comment.
You can think of a segment as some abstract buffer of bytes that can be stored anywhere.
Where ArrayData holds buffers, LayoutData holds segment IDs which can later be resolved to segments.
Hmmm... maybe I should just stick with the name "buffer"
robert3005
reviewed
Jan 3, 2025
Comment on lines
+94
to
+98
| self.state = State::Reading(Reading { | ||
| chunk_idx, | ||
| chunk_layout, | ||
| statistics: None, | ||
| }); |
There was a problem hiding this comment.
I think you want to support out of order reads, if one chunk is very big but you know you have to read the next chunk you don't have to block reading chunk + 1 on previous chunk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of the new structure of vortex layouts per #1676
Up next:
Open Questions: