Fix default tp_init (#221)

spiraldb · Oct 19, 2023 · 5ae9280 · 5ae9280
1 parent 2151bf4
commit 5ae9280
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/pydust/src/pytypes.zig b/pydust/src/pytypes.zig
@@ -267,12 +267,11 @@ fn Slots(comptime definition: type, comptime name: [:0]const u8) type {
             return 0;
         }
 
-        fn tp_init_default(pyself: *ffi.PyObject, pyargs: [*c]ffi.PyObject, pykwargs: [*c]ffi.PyObject) callconv(.C) ?*ffi.PyObject {
+        fn tp_init_default(pyself: *ffi.PyObject, pyargs: [*c]ffi.PyObject, pykwargs: [*c]ffi.PyObject) callconv(.C) c_int {
             _ = pyself;
             _ = pykwargs;
             _ = pyargs;
-            py.TypeError.raise("Native type cannot be instantiated from Python") catch return null;
-            return null;
+            py.TypeError.raise("Native type cannot be instantiated from Python") catch return -1;
         }
 
         /// Wrapper for the user's __del__ function.

diff --git a/test/test_classes.py b/test/test_classes.py
@@ -29,6 +29,11 @@ def test_constructor():
 # --8<-- [end:constructor]
 
 
+def test_non_constructable():
+    with pytest.raises(TypeError):
+        classes.SomeClass()
+
+
 # --8<-- [start:subclass]
 def test_subclasses():
     d = classes.Dog("labrador")