Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init does not use __new__ arguments #173

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Init does not use __new__ arguments #173

merged 3 commits into from
Oct 4, 2023

Conversation

gatesn
Copy link
Contributor

@gatesn gatesn commented Oct 4, 2023

__new__ is only used when constructing the class from Python.

To add factory methods in Zig, they should be wrapped in py.zig

@gatesn gatesn requested a review from robert3005 October 4, 2023 11:32
@gatesn gatesn enabled auto-merge (squash) October 4, 2023 11:54
@gatesn gatesn merged commit cea2c23 into develop Oct 4, 2023
1 check passed
@gatesn gatesn deleted the ngates/init-new branch October 4, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert3005 robert3005 robert3005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gatesn @robert3005