Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource leak #177

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Fix resource leak #177

merged 4 commits into from
Oct 4, 2023

Conversation

gatesn
Copy link
Contributor

@gatesn gatesn commented Oct 4, 2023

Fixes #169

@gatesn gatesn requested a review from robert3005 October 4, 2023 14:02
@gatesn gatesn enabled auto-merge (squash) October 4, 2023 14:02
robert3005
robert3005 reviewed Oct 4, 2023
View reviewed changes
pydust/buildzig.py Outdated Show resolved Hide resolved
@gatesn
Copy link
Contributor Author

gatesn commented Oct 4, 2023

Turns out the leak was actually in the pytest runner not closing stdin/stdout.

Anyway, converted most things to Pathlib

robert3005
robert3005 reviewed Oct 4, 2023
View reviewed changes
pydust/buildzig.py Outdated Show resolved Hide resolved
@gatesn gatesn merged commit 1572a72 into develop Oct 4, 2023
1 check passed
@gatesn gatesn deleted the ngates/fix-resource-leak branch October 4, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert3005 robert3005 robert3005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove custom (and leaky) checksum logic from pydust.build.zig
2 participants
@gatesn @robert3005