[break] Refactor call API #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
reviewed
Oct 4, 2023
robert3005
reviewed
Oct 4, 2023
| } | ||
| defer argsPy.decref(); | ||
|
|
||
| // TODO(ngates): avoid creating empty dict for kwargs |
There was a problem hiding this comment.
it's valid to pass NULL for kwargs in PyObject_Call
There was a problem hiding this comment.
Yeah I know, we just don't atm
robert3005
reviewed
Oct 4, 2023
pydust/src/builtins.zig
Outdated
| } | ||
| defer kwargsPy.decref(); | ||
|
|
||
| // We _must_ return a PyObject to the user to let them handle the lifetime of the object. |
There was a problem hiding this comment.
Oh, hmm.... the comment is actually valid...
There was a problem hiding this comment.
Added a comment to address pass the buck
robert3005
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callable objects can now be called using
py.callandpy.call0, and thePyObject.callmethods now take a method name argument.