Added support for sprite Vector array and Static array in center_camera_on() method #158

MangoS9 · 2023-09-07T13:13:45Z

Description

Added in support for vector array and static array for center_camera_on() method for C++ as calculating multiple sprite locations can be tedious.

void center_camera_on(vector<sprite> s, double offset_x, double offset_y);

parameters:

vector<sprite> s
double offset_x
double offset_y

void center_camera_on(sprite s[],int size , double offset_x, double offset_y);

parameters:

sprite s[]
int size
double offset_x
double offset_y
Both supports vector_2d data sets too:

	//static arr
	void center_camera_on(sprite s[],int size , const vector_2d &offset);
	//vector arr
	void center_camera_on(vector<sprite> s, const vector_2d &offset)

Video demo:

2023-09-07.23-12-04.mp4

Type of change

Overloading the method in camera.cpp and camera.h file
Modified the camera test to check the functionality

How Has This Been Tested?

Tested with Windows 10
Test on single variable, vector array and static array

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Requested a review from seniors on the Pull Request

…ify the test file

macite

This needs work, and should have been reviewed before submitting here. Reviews should critically check basic things like indentation.

macite · 2023-09-09T02:08:18Z

coresdk/src/coresdk/camera.cpp

-    void center_camera_on(sprite s, double offset_x, double offset_y)
-    {
-        point_2d center = sprite_position(s);
+    // void center_camera_on(sprite s, double offset_x, double offset_y)


These comments should not remain in the code. Only include comments that add value.

macite · 2023-09-09T02:08:44Z

coresdk/src/coresdk/camera.cpp

+		double sc_x{0};
+		double sc_y{0};
+
+        for (const auto& ele : s) {


don't use auto

macite · 2023-09-09T02:10:12Z

coresdk/src/coresdk/camera.h

+	 * @param offset_y An additional offset added to the camera, allowing you to
+	 *                 position the sprites offset from the center of the screen.
+	 */
+	void center_camera_on(sprite s[],int size , double offset_x, double offset_y);


I don't think the translator supports arrays - have you tested rebuilding the language translations. See the tools/scripts/deploy.sh script.

macite · 2023-09-09T02:10:25Z

coresdk/src/coresdk/camera.h

+	 * @param offset   The amount to offset the camera, allowing you to position
+	 *                 the sprites away from the center of the screen.
+	 */
+	void center_camera_on(sprite s[], int size, const vector_2d &offset);


macite · 2023-09-09T02:11:58Z

coresdk/src/coresdk/camera.h

     * @attribute method center_on
     */
    void center_camera_on(sprite s, const vector_2d &offset);
+	/**


Very sloppy!

Match indentation.

macite · 2023-09-09T02:12:36Z

coresdk/src/test/test_camera.cpp


    load_bitmap("ufo", "ufo.png");
-    sprite s = create_sprite("ufo");
+    sprite s1 = create_sprite("ufo");


Why not just in the vector and then access them there by index when needed.

Then use a loop to run repeated instructions

macite · 2023-09-09T02:13:11Z

coresdk/src/test/test_camera.cpp

        }

-        update_sprite(s);
+        update_sprite(s1);


macite · 2023-09-09T02:13:17Z

coresdk/src/test/test_camera.cpp

        draw_triangle(COLOR_AQUA, screen_width() / 2, 0, 0, screen_height(), screen_width(), screen_height());

-        draw_sprite(s);
+        draw_sprite(s1);


macite · 2023-09-09T02:13:30Z

coresdk/src/coresdk/camera.cpp

        center_camera_on(s, offset.x, offset.y);
    }
+
+	void center_camera_on(sprite s[],int size , const vector_2d &offset)


MangoS9 · 2023-09-09T03:11:19Z

I will make the changes once I got back to my computer 🙌

MangoS9 · 2023-09-09T03:28:00Z

strangely enough, I didnt notice the indentation error when I'm working on it. Usually VS code should have warned me about it 🙁

MangoS9 · 2023-09-09T10:30:53Z

Update: It seems like the indentation of "camera.h "on my local computer looks fine, I do not know why this happens in github but I will get it fixed real soon and have my senior to get it checked up

MangoS9 · 2023-09-09T11:14:55Z

Update:

fixed the indentation (Hopefully)
Reformat the test_camera code into a more readable manner
Changed "auto" type to "sprite"
Removed all the unnecessary comment in the camera.h
Run the deploy.sh with no issue found

Will get someone to review in case it is wrong again

MangoS9 added 6 commits September 7, 2023 22:44

added support for vector and static array for the camera.h, while mod…

7313b8b

…ify the test file

forget the support for vector_2d

2a2f649

forget the support for vector_2d

ed93c38

fix

3337107

fix

b17c84c

fix the test

486d19d

macite requested changes Sep 9, 2023

View reviewed changes

macite marked this pull request as draft September 9, 2023 02:15

MangoS9 added 3 commits September 9, 2023 21:18

fix everything that is mention by andrew

ed76414

fix indentation for camera.cpp (I have no idea how this happens)

28d6f56

just replace a head to a different place

fdfe948

MangoS9 marked this pull request as ready for review September 10, 2023 04:18

MangoS9 requested a review from macite September 11, 2023 22:14

MangoS9 closed this by deleting the head repository Sep 13, 2023

222448082Ashen mentioned this pull request Dec 21, 2025

Add SplashKit native libraries to NuGet package, including test suite thoth-tech/splashkit-core#149

Open

7 tasks

Added support for sprite Vector array and Static array in center_camera_on() method #158

Added support for sprite Vector array and Static array in center_camera_on() method #158

Uh oh!

Conversation

MangoS9 commented Sep 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

macite left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MangoS9 commented Sep 9, 2023

Uh oh!

MangoS9 commented Sep 9, 2023

Uh oh!

MangoS9 commented Sep 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MangoS9 commented Sep 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MangoS9 commented Sep 7, 2023 •

edited

Loading

MangoS9 commented Sep 9, 2023 •

edited

Loading

MangoS9 commented Sep 9, 2023 •

edited

Loading