compose previews #834
compose previews #834
Conversation
| */ | ||
| class ApplicationHolder { |
There was a problem hiding this comment.
unsure whether class + companion object combination was intentional
| field = application | ||
| object ApplicationHolder { | ||
|
|
||
| private var _applicationContext: Context? = null |
There was a problem hiding this comment.
android system does not really use an Application object but relies on the Context
There was a problem hiding this comment.
I think it was mostly a way to use types to guarantee the context set was the actual application context and not an Activity context by accident
| actual class DefaultFontLoader(private val context: Context?) : FontLoader { | ||
| actual constructor() : this(if (ApplicationHolder.isInitialized) ApplicationHolder.applicationContext else null) | ||
| actual override fun loadFont(identifier: String, defaultValue: KalugaFont?): KalugaFont? = | ||
| context?.getResource(identifier, DefType.font) { id -> ResourcesCompat.getFont(context, id) } |
There was a problem hiding this comment.
converted to using blocking call after all
Code coverage
|
| defaultValue | ||
| } | ||
| } | ||
| actual constructor() : this(if (ApplicationHolder.isInitialized) ApplicationHolder.applicationContext else null) |
There was a problem hiding this comment.
I realize this is just existing behaviour, but since you've been looking at the code here... is the idea when proceeding with null that it's for previews / unit tests or something? It's such strange behaviour.
|
breaks example, at least this time we know from CI :) |
#763