feat: add support to supply a CA cert for untrusted CA certs #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a mechanism to supply a CA certificate to use in validation of the SSL endpoint for splicectl-api. This allows use of self-signed certs or certs that are signed by an untrusted CA.
The primary work is done in main.go. Reading from --cacert and SPLICECTL_CACERT. The rest of the edits are all the same, consuming the caBundle set in main.go and passing it to the goresty object.
Motivation and Context
In many on-prem installation we may not have a CA issued for POC and need a way to handle self-signed certificates.
Dependencies
How Has This Been Tested?
The functionality remains exactly the same if
--cacert
orexport SPLICECTL_CACERT=
are not specified or set.Screenshots (if appropriate)
Checklist
If the pull request includes user-facing changes, extra documentation is required:
Changelog Inclusions
Additions
Changes
Fixes
Deprecated
Removed
Breaking Changes