Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Envvars for Snowflake adapter #414

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Envvars for Snowflake adapter #414

merged 3 commits into from
Mar 26, 2021

Conversation

mildbyte
Copy link
Contributor

Add support for passing environment variables to the Snowflake adapter (e.g. HTTP_PROXY / HTTPS_PROXY / NO_PROXY etc).

Example:

$ sgr mount snowflake test_snowflake -o@- <<EOF
{
    "username": "username",
    "password": "password",
    "account": "account.region.vendor",
    "database": "SNOWFLAKE_SAMPLE_DATA",
    "schema": "TPCH_SF100",
    "envvars": {"HTTPS_PROXY": "https://proxy.company.com"}
}
EOF

Fixes #413

mildbyte added 3 commits March 25, 2021 21:24
@mildbyte
Add support for passing environment variables to the Snowflake adapte…
cbf1b27 
…r (e.g. `HTTP_PROXY` / `HTTPS_PROXY` / `NO_PROXY` etc) (pass an `"envvars": {"HTTPS_PROXY": "https://..."}` to the FDW params)
@mildbyte
Bump Multicorn to:
1f0f13d 
  * switch envvars back at the end of the execution
  * limit allowed envvars to `HTTP_PROXY`, `HTTPS_PROXY`, `NO_PROXY`.
@mildbyte
Fix bug with wrong dburl construction when warehouse/role are present
79b8e4a
@mildbyte mildbyte merged commit 5d19e35 into master Mar 26, 2021
@mildbyte mildbyte deleted the feature/snowflake-sqlalchemy-envvars branch March 26, 2021 22:06
mildbyte added a commit that referenced this pull request Mar 29, 2021
@mildbyte
Bump version: 0.2.10 → 0.2.11
f84b245 
  * Snowflake data source improvements:
    * Allow passing envvars to set HTTP proxy parameters, fix incorrect query string generation when passing a warehouse (#414, #413)
    * Support for authentication using a private key (#418)
  * Splitfiles: relax AST restrictions to support all SELECT/INSERT/UPDATE/DELETE statements (#411)
  * Change the default installation port to 6432 and handle port conflicts during install (#375)
  * Add retry logic to fix registry closing the SSL connection after 30 seconds, close remote connections in some places (#417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot mount Snowflake as a data source behind a proxy
1 participant
@mildbyte