Fixes to CSV encoding/line endings/dialect inference #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mildbyte
commented
Apr 7, 2021
mildbyte
commented
- Autodetect the encoding using chardet
- Add more configuration to the CSV plugin for: encoding, dialect (e.g. "excel"), sample size for inference
- Bump the sample size to 64KB to have a better chance of inferring the dialect for wider tables
- Autogenerate column names for unnamed columns
- Handle Mac-style and other newlines (universal newlines mode)
…to a separate module. Get the CSV plugin to also infer the file's encoding and get it to handle Windows line endings properly. Also make the sample size for inference customizable.
….g. col_1) since PG doesn't like empty column names. Add an integration test for the end-to-end querying + import through FDW with an unnamed column.
…a test for Mac-style newlines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.