-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airbyte data source [CU-15xp9xt] #493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at can be referenced by non-Singer data sources.
… the source path.
…d use it for source containers too (in test we want to hit the MySQL Docker container from the host).
…it them; ignore log lines that aren't Airbyte messages.
…for the destination, we want to override the namespace since otherwise PG will write out to the wrong schema).
…loader as a test).
… from it into the codebase, since that's all we need. Update the Poetry lockfile.
…ues with Docker log batch size (16364).
…ar imports (since plugins are loaded in the commandline module).
7be2128
to
5302bef
Compare
…hout various image creation routines instead of ad hoc numbers.
…ta sources (through `airbyte_cursor_field` and `airbyte_primary_key` table params). Also, report the plugin's default cursor/PK back to the user at introspection time (as suggested default table params).
6696b32
to
6cd734a
Compare
… (table params can be anything that dumps to JSON).
… data source through a function rather than at instantiation time.
mildbyte
added a commit
that referenced
this pull request
Jul 26, 2021
* API functionality to get the raw URL for a data source (#457) * LQ scan / filtering simplification to speed up writes / Singer loads (#464, #489) * API functionality for Airbyte support (`AirbyteDataSource` class, #493) * Speed up `sgr cloud load` by bulk API calls (#500) Full set of changes: [`v0.2.14...v0.2.15`](v0.2.14...v0.2.15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intro
Splitgraph
DataSource
implementation for connectors that use the Airbyte standard.Similar to Singer (some Airbyte taps wrap around Singer) but with a few benefits:
Not exposed publicly: this is just an
AirbyteDataSource
class that can be inherited from with some overrides to make an SG-compatible data source.Example for MySQL:
Implementation:
--spec
but this is currently done OOB._airbyte_raw_[streamname]
.sgr checkout
-- we just manually link these tables to the previous version (extending the Splitgraph table)Limitations
References: