Skip to content

Conversation

@EmilianoSanchez
Copy link
Contributor

JS Browser SDK

What did you accomplish?

  • Revert removal of TypeScript SplitIO namespace at /types/splitio.d.ts to allow explicit imports of types from the Browser SDK package. E.g., import type { IClientSideSettings } from '@splitsoftware/splitio-browserjs/types/splitio';.

How do we test the changes introduced in this PR?

  • Added asserts in TS tests.

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner November 7, 2024 16:57
Copy link
Contributor

@lenasano lenasano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small and quick changes suggested.

EmilianoSanchez and others added 3 commits November 11, 2024 10:57
Co-authored-by: lenasano <114319916+lenasano@users.noreply.github.com>
@sonarqube-pull-requests
Copy link

@EmilianoSanchez EmilianoSanchez merged commit b9ecaaa into development Nov 11, 2024
8 checks passed
@EmilianoSanchez EmilianoSanchez deleted the type_declarations_update branch November 11, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants