Skip to content

Commit

Permalink
update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
EmilianoSanchez committed Oct 10, 2023
1 parent c33449d commit 8e55350
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions src/storages/AbstractSegmentsCacheSync.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export abstract class AbstractSegmentsCacheSync implements ISegmentsCacheSync {

/**
* Only used for the `skC`(segment keys count) telemetry stat: 1 for client-side, and total count of keys in server-side.
* @TODO for client-side it should be the number of clients, but it requires a refactor of MySegments caches to simplify the code.
*/
abstract getKeysCount(): number

Expand Down
1 change: 0 additions & 1 deletion src/storages/inMemory/TelemetryCacheInMemory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ export class TelemetryCacheInMemory implements ITelemetryCacheSync {
iDr: this.getImpressionStats(DROPPED),
spC: this.splits && this.splits.getSplitNames().length,
seC: this.segments && this.segments.getRegisteredSegments().length,
// @TODO number of clients in client-side API?
skC: this.segments && this.segments.getKeysCount(),
sL: this.getSessionLength(),
eQ: this.getEventStats(QUEUED),
Expand Down

0 comments on commit 8e55350

Please sign in to comment.