Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDKS-7463] Add new bySet filter #238

Merged
merged 2 commits into from
Aug 30, 2023
Merged

[SDKS-7463] Add new bySet filter #238

merged 2 commits into from
Aug 30, 2023

Conversation

emmaz90
Copy link
Contributor

@emmaz90 emmaz90 commented Aug 25, 2023

Javascript commons library

What did you accomplish?

  • Added new bySet filter type in splitFilters configuration
  • Validate

How do we test the changes introduced in this PR?

  • Unit tests included

Extra Notes

@emmaz90 emmaz90 requested a review from a team as a code owner August 25, 2023 00:26
EmilianoSanchez
EmilianoSanchez approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved Emma, but there are some style and typo fixes to check

src/logger/messages/warn.ts Outdated Show resolved Hide resolved
src/logger/messages/warn.ts Outdated Show resolved Hide resolved
src/utils/settingsValidation/__tests__/splitFilters.spec.ts Outdated Show resolved Hide resolved
@emmaz90 emmaz90 merged commit 396bfbd into sdks-7437 Aug 30, 2023
@emmaz90 emmaz90 deleted the sdks-7463 branch August 30, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilianoSanchez EmilianoSanchez EmilianoSanchez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmaz90 @EmilianoSanchez