Skip to content

Conversation

@emmaz90
Copy link
Contributor

@emmaz90 emmaz90 commented Aug 25, 2023

Javascript commons library

What did you accomplish?

  • Added new bySet filter type in splitFilters configuration
  • Validate

How do we test the changes introduced in this PR?

  • Unit tests included

Extra Notes

@emmaz90 emmaz90 requested a review from a team as a code owner August 25, 2023 00:26
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved Emma, but there are some style and typo fixes to check

@emmaz90 emmaz90 merged commit 396bfbd into sdks-7437 Aug 30, 2023
@emmaz90 emmaz90 deleted the sdks-7463 branch August 30, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants