Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDKS-7793] Add flag sets support in pluggable storage #272

Merged
merged 6 commits into from
Nov 27, 2023
Merged

[SDKS-7793] Add flag sets support in pluggable storage #272

merged 6 commits into from
Nov 27, 2023

Conversation

EmilianoSanchez
Copy link
Contributor

Javascript commons library

What did you accomplish?

  • Implement SplitsCachePluggable::getNamesByFlagSets method for consumer and partial consumer modes.
  • Update SplitsCachePluggable::addSplit and SplitsCachePluggable::removeSplit methods to update flag sets for producer mode.

How do we test the changes introduced in this PR?

  • [TODO] Unit tests

Extra Notes

@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review November 24, 2023 17:02
@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner November 24, 2023 17:02
javrudsky
javrudsky approved these changes Nov 27, 2023
View reviewed changes
Copy link

@javrudsky javrudsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EmilianoSanchez EmilianoSanchez merged commit 5b833ab into flagsets_baseline Nov 27, 2023
1 check passed
@EmilianoSanchez EmilianoSanchez deleted the SDKS-7793-flagsets_in_pluggable_storage branch November 27, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmayorsplit nmayorsplit nmayorsplit approved these changes

@javrudsky javrudsky javrudsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmilianoSanchez @javrudsky @nmayorsplit