Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis Adapter fixes #275

Merged
merged 32 commits into from
Dec 1, 2023
Merged

Redis Adapter fixes #275

merged 32 commits into from
Dec 1, 2023

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Nov 29, 2023 •
edited
Loading

Javascript commons library

What did you accomplish?

  • Updated unit tests for Redis storage to use the Redis Adapter rather than a ioredis instance directly.This approach helped us identify and fix an issue with the Redis Adapter:
  • Fixed Redis Adapter to handle the timeout and queueing of some missing operations ('hincrby', 'popNRaw').

How do we test the changes introduced in this PR?

  • Unit tests

Extra Notes

Base automatically changed from SDKS-7794-flagsets_in_redis_storage to flagsets_baseline November 29, 2023 20:09
@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review November 30, 2023 16:03
@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner November 30, 2023 16:03
@EmilianoSanchez EmilianoSanchez changed the title Redis storage improvements Redis Adapter improvements Nov 30, 2023
@EmilianoSanchez EmilianoSanchez changed the title Redis Adapter improvements Redis Adapter fixes Nov 30, 2023
NicoZelaya
NicoZelaya approved these changes Nov 30, 2023
View reviewed changes
src/storages/inRedis/RedisAdapter.ts Outdated Show resolved Hide resolved
@EmilianoSanchez EmilianoSanchez merged commit f5861d8 into flagsets_baseline Dec 1, 2023
1 check passed
@EmilianoSanchez EmilianoSanchez deleted the redis_storage_improvements branch December 1, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoZelaya NicoZelaya NicoZelaya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilianoSanchez @NicoZelaya