Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manager methods to return a promise in consumer modes while the SDK is not operational #276

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Update manager methods to return a promise in consumer modes while the SDK is not operational #276

merged 3 commits into from
Nov 30, 2023

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Nov 30, 2023 •
edited
Loading

Javascript commons library

What did you accomplish?

  • Fixed manager methods to return the value wrapped in a promise in consumer modes when called while the SDK is not operational (i.e., not ready or destroyed).

How do we test the changes introduced in this PR?

  • Unit tests

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner November 30, 2023 15:01
javrudsky
javrudsky approved these changes Nov 30, 2023
View reviewed changes
Copy link

@javrudsky javrudsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EmilianoSanchez EmilianoSanchez merged commit 7070b14 into development Nov 30, 2023
2 checks passed
@EmilianoSanchez EmilianoSanchez deleted the manager_async_fix branch November 30, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javrudsky javrudsky javrudsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilianoSanchez @javrudsky