[FME-10567] Add fallbackTreatmentCalculator to evaluator #443
Conversation
| splitName: string, | ||
| attributes: SplitIO.Attributes | undefined, | ||
| storage: IStorageSync | IStorageAsync, | ||
| fallbackTreatmentsCalculator: FallbackTreatmentsCalculator, |
There was a problem hiding this comment.
We should move where the fallbackTreatmentsCalculator is called, to contemplate other cases of CONTROL treatments:
- SDK is not ready
- SDK is destroyed
getTreatmentarguments are invalid
For the 1st, we should call the calculator in the client.ts file. For example, in the wrapUp functions.
For the 2nd and 3rd case, we should call the calculator in the clientInputValidation.ts file. For example, inside the wrapResult function if possible, to have the logic in a single place.
This way, we don't need to call the calculator in the evaluator/index.ts file, and probably all updates in the evaluator folder (except the fallbackTreatmentsCalculator subfolder) can be rolled back to simplify the code.
There was a problem hiding this comment.
Sounds good Emi, thanks for the feedback! I am closing this pr and develop that approach in this new PR
2 participants
JavaScript commons library
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes