Merge pull request #209 from splitio/fix/iv_empty_str

fix input validation for empty keys

.github/CODEOWNERS

@@ -0,0 +1 @@
+* @splitio/sdk

CHANGES.txt

@@ -1,3 +1,6 @@
+7.1.8 (Jul 24, 2023)
+ - Fixed input validation for empty keys.
+
 7.1.7 (May 16, 2023)
  - Updated terminology on the SDKs codebase to be more aligned with current standard without causing a breaking change. The core change is the term split for feature flag on things like logs and phpdoc comments.
  - Fixed php 8.2 warnings in code.

src/SplitIO/Sdk/Validator/InputValidator.php

@@ -69,7 +69,7 @@ private static function checkIsNull($value, $name, $nameType, $operation)
     private static function checkIsEmpty($value, $name, $nameType, $operation)
     {
         $trimmed = trim($value);
-        if (empty($trimmed)) {
+        if (0 == strlen($trimmed)) {
             SplitApp::logger()->critical($operation . ": you passed an empty " . $name . ", " . $nameType .
                 " must be a non-empty string.");
             return true;
@@ -265,7 +265,7 @@ function ($featureFlagName) use ($operation) {
                 )
             )
         );
-        if (empty($filteredArray)) {
+        if (0 == count($filteredArray)) {
             SplitApp::logger()->critical($operation . ': featureFlagNames must be a non-empty array.');
             return null;
         }

src/SplitIO/Version.php

@@ -3,5 +3,5 @@
 
 class Version
 {
-    const CURRENT = '7.1.7';
+    const CURRENT = '7.1.8';
 }

tests/Suite/InputValidation/GetTreatmentValidationTest.php

@@ -57,6 +57,7 @@ public function testGetTreatmentWithEmptyMatchingKeyObject()
         $splitSdk = $this->getFactoryClient();
 
         $this->assertEquals('control', $splitSdk->getTreatment(new Key('', 'some_bucketing_key'), 'some_feature'));
+        $this->assertNotEquals('control', $splitSdk->getTreatment(new Key("0", 'some_bucketing_key'), 'some_feature'));
     }
 
     public function testGetTreatmentWithWrongTypeMatchingKeyObject()