Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Allowing Multiple Factory Instantiation #194

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

[WIP] Allowing Multiple Factory Instantiation #194

wants to merge 45 commits into from

Conversation

mmelograno
Copy link
Contributor

@mmelograno mmelograno commented Nov 17, 2022 •
edited
Loading

PHP SDK

What did you accomplish?

  • Removed cache from Di.
  • Attached cache into ImpressionCache, EventsCache, SplitCache and SegmentCache.
  • Send storages to Client and Manager.
  • Added context for Evaluator to be used in SegmentMatcher.
  • Remove Splitter from Di and made it static.
  • Updated MultipleFactoryInstantiation logic to allow it.
  • Di component was replaced in favor of Context

How do we test the changes introduced in this PR?

Extra Notes

@mmelograno mmelograno changed the base branch from develop to master November 17, 2022 16:41
mmelograno and others added 28 commits November 17, 2022 13:50
@mmelograno
linting fixes
e089f2b
@mmelograno
updated Splitter test for TrafficAllocation
b08c536
@mmelograno
removed comments
49cd135
@mmelograno
removed comments
5c7e754
@mmelograno
updated di logger
f7a8d13
@mmelograno
feedback
c5a8afb
@mmelograno
Merge branch 'task/multipleFactory' of github.com:splitio/php-client …
e923e71 
…into task/DiLogger
@github-actions
Updated License Year
ebbbc6b
@mmelograno
updated Di component
1f403cc
@mmelograno
removed unnecesary private methods
4daa3be
@mmelograno
Merge pull request #196 from splitio/task/DiLogger
8154328 
Task/di logger
@mmelograno
Merge branch 'task/multipleFactory' of github.com:splitio/php-client …
5b46045 
…into task/multipleFactory
@mmelograno
removed support for php 7
47d9d1d
@mmelograno
removed support for php 7
54b7977
@mmelograno
Merge pull request #195 from splitio/update-license
b0eda71 
Update License Year
@mmelograno
support for php 7.4
6cebe69
@mmelograno
Merge branch 'task/multipleFactory' of github.com:splitio/php-client …
a5f3d30 
…into task/multipleFactory
@mmelograno
added tracker component
eb1e875
@mmelograno
tracking instances
ca411b9
@mmelograno
improved logging multiple factories
7dcc25e
@mmelograno
Merge pull request #197 from splitio/task/trackerComponent
d514aad 
Task/tracker component
@mmelograno
Merge branch 'task/multipleFactory' of github.com:splitio/php-client …
86cc2bc 
…into task/multipleFactory
@mmelograno
updated log lines
ad6c40c
@mmelograno
replaced Di in favor of Context
7d3a093
@mmelograno
removed unused imports
092d94c
@mmelograno
Merge pull request #198 from splitio/task/context
bc08632 
replaced Di in favor of Context
@mmelograno
Merge branch 'task/multipleFactory' of github.com:splitio/php-client …
61ed071 
…into task/multipleFactory
@mmelograno
resetting context for integration tests
bffeba0
@sonarqube-pull-requests
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

gthea
gthea previously approved these changes Jan 20, 2023
View reviewed changes
src/SplitIO/Sdk/Client.php Outdated Show resolved Hide resolved
src/SplitIO/Sdk/Factory/SplitFactory.php Outdated Show resolved Hide resolved
@sonarqube-pull-requests
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@sonarqube-pull-requests
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

93.1% 93.1% Coverage
0.3% 0.3% Duplication

@mmelograno mmelograno requested a review from a team as a code owner February 1, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gthea gthea gthea left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmelograno @gthea