-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False-positive diff change when comparing a large hash #100
Comments
Thanks for the report, that's weird for sure. I'll check it out shortly! |
I've experienced a similar issue. Downgrading to |
groyoh
added a commit
to happydemics/super_diff
that referenced
this issue
May 5, 2021
When a key in the `actual` results in a noop and its key index in the `expected` is less than its index in the `actual`, the diff would display a `delete` for this key along with a noop. For instance, in the diff below we have `- profile_background_tile: false,` and ` profile_background_tile: false`. ``` Differing hashes. Expected: { created_at: "Tue Jan 13 19:28:24 +0000 2009", favourites_count: 38, geo_enabled: false, verified: true, media_count: 51044, statuses_count: 273860, contributors_enabled: false, profile_background_image_url_https: "https://abs.twimg.com/images/themes/theme1/bg.png", profile_background_color: "FFF1E0", profile_background_tile: false, profile_image_url: "http://pbs.twimg.com/profile_images/931156393108885504/EqEMtLhM_normal.jpg", listed_count: 37009, profile_banner_url: "https://pbs.twimg.com/profile_banners/18949452/1581526592" } Actual: { listed_count: 37009, created_at: "Tue Jan 13 19:28:24 +0000 2009", favourites_count: 38, utc_offset: nil, statuses_count: 273860, media_count: 51044, contributors_enabled: false, is_translator: false, is_translation_enabled: false, profile_background_color: "FFF1E0", profile_background_image_url_https: "https://abs.twimg.com/images/themes/theme1/bg.png", profile_banner_url: "https://pbs.twimg.com/profile_banners/18949452/1581526592", profile_background_tile: false } Diff: { listed_count: 37009, created_at: "Tue Jan 13 19:28:24 +0000 2009", favourites_count: 38, - geo_enabled: false, - verified: true, + utc_offset: nil, statuses_count: 273860, media_count: 51044, contributors_enabled: false, + is_translator: false, + is_translation_enabled: false, profile_background_color: "FFF1E0", profile_background_image_url_https: "https://abs.twimg.com/images/themes/theme1/bg.png", - profile_background_tile: false, - profile_image_url: "http://pbs.twimg.com/profile_images/931156393108885504/EqEMtLhM_normal.jpg", profile_banner_url: "https://pbs.twimg.com/profile_banners/18949452/1581526592", profile_background_tile: false } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There should not have
"inspection_doctor"
indiff
in that they are the same both in expected and in actual.See the screenshots:
This is the test cases:
Environment
The text was updated successfully, but these errors were encountered: