Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SuperDiff respect extra_failure_lines metadata of RSpec #195

Closed
wants to merge 1 commit into from

Conversation

willnet
Copy link
Contributor

@willnet willnet commented Aug 14, 2023

Fix #108

@thimo
Copy link

thimo commented Oct 31, 2023

Thank you sooo much for this PR. Makes my live much easier by no longer have to switch super_diff on and off again and have either screenshots or nice diffs. Now I can have my cake and eat it too. 😍 Again, thanks!!

@mcmire
Copy link
Collaborator

mcmire commented Jan 22, 2024

Hi @willnet! So sorry that it took me a while to get to this PR. I have made a couple of tweaks to this PR and have merged it as #208, giving you credit. Thanks for your submission! I'll release a new version soon and post back when it's publicly available.

@mcmire mcmire closed this Jan 22, 2024
@willnet willnet deleted the add-extra_failure_lines branch January 23, 2024 05:09
@mcmire
Copy link
Collaborator

mcmire commented Feb 10, 2024

This fix has been included in v0.11.0. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SuperDiff doesn't respect extra_failure_lines metadata of RSpec
3 participants