Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide support for Python 3.9 for OS-dependent libraries #1338

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

feat: Provide support for Python 3.9 for OS-dependent libraries #1338

wants to merge 11 commits into from

Conversation

lplonka-splunk
Copy link
Contributor

@lplonka-splunk lplonka-splunk commented Sep 12, 2024 •
edited
Loading

Issue number:
ADDON-73695

Summary

Provide support for Python 3.9 for OS-dependent libraries

Changes

Please provide a summary of what's being changed

  • Add validation of python version for os dependent libraries in global_config.json [schema]
  • Add validation of conflicting target paths of os dependent libraries
  • Extend sys path depending also on python version

User experience

--

Please describe what the user experience looks like before and after this change
--

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@lplonka-splunk lplonka-splunk marked this pull request as ready for review September 12, 2024 08:47
@lplonka-splunk lplonka-splunk requested review from a team as code owners September 12, 2024 08:47
@artemrys
Copy link
Member

Making it a draft as it is not ready for review.

@artemrys artemrys marked this pull request as draft September 17, 2024 14:30
@lplonka-splunk lplonka-splunk marked this pull request as ready for review September 18, 2024 10:44
@lplonka-splunk
Copy link
Contributor Author

Ready for review - tested on MS security

sgoral-splunk
sgoral-splunk reviewed Sep 20, 2024
View reviewed changes
docs/advanced/os-dependent_libraries.md
Comment on lines +33 to +36
Currently supported python versions are "3.7" and "3.9". Syntax without dots ("37" or "39") is also supported.

If there are libraries specified for different python versions, they must have different target paths.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add some example of that in the usage below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoral-splunk sgoral-splunk sgoral-splunk approved these changes

@artemrys artemrys Awaiting requested review from artemrys

@kkedziak-splunk kkedziak-splunk Awaiting requested review from kkedziak-splunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lplonka-splunk @artemrys @sgoral-splunk