Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mlmodel changes bug #199

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Fix mlmodel changes bug #199

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
580b015
Fix bug which causes failure on mode:changes for modified .mlmodel fi…
pyth0n1c Jul 19, 2024
331d4ff
bump patch version in pyproject.toml
pyth0n1c Jul 19, 2024
57f6238
Merge branch 'main' into fix_mlmodel_changes_bug
patel-bhavin Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions contentctl/actions/detection_testing/GitService.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,19 @@ def getChanges(self, target_branch:str)->List[Detection]:
raise Exception(f"More than 1 Lookup reference the modified CSV file '{decoded_path}': {[l.file_path for l in matched ]}")
else:
updatedLookup = matched[0]
elif decoded_path.suffix == ".mlmodel":
# Detected a changed .mlmodel file. However, since we do not have testing for these detections at
# this time, we will ignore this change.
updatedLookup = None


else:
raise Exception(f"Error getting lookup object for file {str(decoded_path)}")
raise Exception(f"Detected a changed file in the lookups/ directory '{str(decoded_path)}'.\n"
"Only files ending in .csv, .yml, or .mlmodel are supported in this "
"directory. This file must be removed from the lookups/ directory.")

if updatedLookup not in updated_lookups:
# It is possible that both th CSV and YML have been modified for the same lookup,
if updatedLookup is not None and updatedLookup not in updated_lookups:
# It is possible that both the CSV and YML have been modified for the same lookup,
# and we do not want to add it twice.
updated_lookups.append(updatedLookup)

Expand Down
Loading