Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Mark "breaker" as obsolete #715

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wmazur-splunk
Copy link

"Breaker" variable shall be considered discouraged since it takes TA's work to break the events. This way we do not test add-on but samples config.

@codecov-commenter
Copy link

Codecov Report

Merging #715 (18a01d2) into develop (1eec65a) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop     #715      +/-   ##
===========================================
- Coverage    86.86%   86.84%   -0.02%     
===========================================
  Files           51       51              
  Lines         2771     2775       +4     
===========================================
+ Hits          2407     2410       +3     
- Misses         364      365       +1     
Impacted Files Coverage Δ
...on/standard_lib/sample_generation/sample_stanza.py 88.46% <80.00%> (-0.32%) ⬇️
...k_addon/standard_lib/index_tests/test_generator.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@uoboda-splunk
Copy link
Contributor

Please fix pre-commit

Base automatically changed from develop to main November 29, 2022 12:26
@artemrys artemrys marked this pull request as draft September 4, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants