Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Userguide enhancements #890

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Conversation

dvarasani-crest
Copy link
Contributor

@dvarasani-crest dvarasani-crest commented Sep 5, 2024

This PR updates the doc for how_to_use section and add the documentation for requirement tests.
ref: https://splunk.atlassian.net/browse/ADDON-73384

@dvarasani-crest dvarasani-crest marked this pull request as ready for review September 10, 2024 08:59
@dvarasani-crest dvarasani-crest requested a review from a team as a code owner September 10, 2024 08:59
@artemrys artemrys self-requested a review September 10, 2024 13:16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this PR - let's rework this file.

"How to use" would be on the first if not the first pages users would like to go to understand how PSA works.

Let's start with some prerequisites, like they have an add-on or an app (please include links to the Splexicon) and they want to make sure their props / transforms are correct. And let's walk a developer through the steps they need to execute to be able to run a successful test when an event is ingested to Splunk, proper test cases are created and tests are executed.

Imagine that you give these instructions to a new joiner who does not know anything about Splunk, TAs and PSA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will add the details regarding prerequisites and how psa works in the "Home" page. After covering all these details we can put the link to "how_to_use" section to walk the developers through how they can execute the tests

Search = <Query>
```

Get the search query from the stack trace and execute it on the Splunk instance and verify which specific event is causing failure.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here searching the query in splunk won't provide much info as we are processing the fields in the test itself, may be we can add what assertion error would show in case of failures.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added sample of assertion error message

pytest-splunk-addon is an open-source dynamic test plugin for Splunk Apps and Add-ons
which allows the user to test knowledge objects, CIM compatibility and index time properties.
pytest-splunk-addon is an open-source dynamic test plugin for Splunk [Apps](https://docs.splunk.com/Splexicon:App) and [Add-ons](https://docs.splunk.com/Splexicon:Addon)
which allows the user to test [knowledge objects](https://docs.splunk.com/Splexicon:Knowledgeobject), [CIM](https://docs.splunk.com/Splexicon:CommonInformationModel) compatibility and [index time properties](https://docs.splunk.com/Splexicon:Indexedfield).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify these links are working?
I did mkdocs serve in my local and its shows just plain text

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I verified those links and they are working as expected.

@dvarasani-crest dvarasani-crest merged commit 5cf1bd4 into main Sep 26, 2024
21 of 22 checks passed
@dvarasani-crest dvarasani-crest deleted the docs/userguide-enhancements branch September 26, 2024 06:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 5.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants