Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --api-versions flag for helm template #257

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kvaps
Copy link
Contributor

@kvaps kvaps commented Sep 17, 2021

This PR adds support for passing --api-versions to helm template command.
Many charts containing lookup functions, which allow to check if Kubernetes cluster supports specific apiVersions
https://helm.sh/docs/chart_template_guide/functions_and_pipelines/#using-the-lookup-function

@kvaps kvaps changed the title Add --api-versions flag support for helm template Add support for --api-versions flag for helm template Sep 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #257 (c6695dc) into master (5508c45) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   73.87%   73.88%   +0.01%     
==========================================
  Files          72       72              
  Lines        5015     5017       +2     
==========================================
+ Hits         3705     3707       +2     
  Misses       1101     1101              
  Partials      209      209              
Impacted Files Coverage Δ
vm/internal/natives/helm.go 90.24% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5508c45...c6695dc. Read the comment docs.

@harsimranmaan
Copy link
Contributor

@kvaps qbec know supports external datasources https://qbec.io/reference/jsonnet-external-data/. It is possible to use helm(or any other tool) in a generic way without requiring native functions. @gotwarlost maybe we should looking at dropping the expandHelmTemplate in a future release

@Andor
Copy link

Andor commented Nov 27, 2023

@harsimranmaan since #286 function expandHelmTemplate might be considered as a stable one. Could you please merge this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants